<i18n dev> Integrated: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
Justin Lu
jlu at openjdk.org
Tue Jul 11 17:15:21 UTC 2023
On Thu, 29 Jun 2023 18:02:00 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR, which clarifies the parameter description of ChoiceFormat.setChoices().
>
> `ChoiceFormat.setChoices(double[] limits, String[] formats)` claims that `formats` can either be "Format objects or Strings". It also claims that "When formatting with object Y, if the object is a NumberFormat, then ((NumberFormat) Y).format(X) is called. Otherwise Y.toString() is called".
>
> This is not true as `formats` is an array of Strings. Thus, the second claim is impossible and unimplemented in the method itself.
>
> The unimplemented specification should be removed from the parameter description.
This pull request has now been integrated.
Changeset: 6cb9ec32
Author: Justin Lu <jlu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
Reviewed-by: naoto
-------------
PR: https://git.openjdk.org/jdk/pull/14715
More information about the i18n-dev
mailing list