<i18n dev> RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]

[Justin Lu]

On Mon, 17 Jul 2023 10:58:12 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Review: Explicitly run via othervm and pass locale args in cmdline
>>  - Review: ws removal in Bug8179071.java
>>  - Review: remove redudant 'throws'
>>  - Review: Use assertTrue() in Bug8179071.java
>>  - Review: Revert "Same as prev commit"
>>    
>>    This reverts commit 933c0312ed2fa0f40a750e950c166b7e820df7ab.
>>  - Review: Revert "Remove try catch in Bug8135061.java"
>>    
>>    This reverts commit f213c74e37ed257a05a535b2c077af327343acb5.
>
> test/jdk/java/util/Locale/Bug8179071.java line 95:
> 
>> 93:                 .forEach(tag -> {if(LegacyAliases.contains(tag)) {invalidTags.add(tag);}});
>> 94:         assertEquals(true, invalidTags.isEmpty(),
>> 95:                 "Deprecated and Legacy tags found  " + invalidTags  + " in AvailableLocales ");
> 
> Suggestion:
> 
>                 "Deprecated and Legacy tags found  " + invalidTags + " in AvailableLocales ");

Thanks, updated this and the other suggested WS change

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14881#discussion_r1265919052