<i18n dev> RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v2]

Justin Lu jlu at openjdk.org
Wed Jul 19 18:46:46 UTC 2023


On Tue, 18 Jul 2023 22:09:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Slight wording adjustment
>>  - Review: Explicitly declare when NPE thrown instead of 'may'
>
> src/java.base/share/classes/java/text/MessageFormat.java line 407:
> 
>> 405:      * @throws    NullPointerException This method throws a
>> 406:      *            {@code NullPointerException} if {@code locale} is {@code null}
>> 407:      *            and a localized subformat is used.
> 
> NPE throws tags should be combined. Applies to other locations too.

Thanks for the follow up review, I have fixed this and the 'localized' wording. I have also updated the CSR to reflect the most recent changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14911#discussion_r1268509743


More information about the i18n-dev mailing list