<i18n dev> RFR: 8313231: Redundant if statement in ZoneInfoFile

Jie Fu jiefu at openjdk.org
Thu Jul 27 07:07:40 UTC 2023


On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang <jjiang at openjdk.org> wrote:

> if (i < savingsInstantTransitions.length) {
>     // javazic writes the last GMT offset into index 0!
>     if (i < savingsInstantTransitions.length) {
>         offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000;
>         nOffsets = 1;
>     }
>     ...
> }
> 
> 
> The second if statement looks unnecessary.

LGTM

-------------

Marked as reviewed by jiefu (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15052#pullrequestreview-1549140091


More information about the i18n-dev mailing list