<i18n dev> RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales [v2]

[Aleksey Shipilev]

On Fri, 28 Jul 2023 16:53:51 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change to Locale.US
>
> test/jdk/java/util/Formatter/Padding.java line 312:
> 
>> 310:     @MethodSource
>> 311:     void padding(String expected, String format, Object value) {
>> 312:         assertEquals(expected, String.format(Locale.ROOT, format, value));
> 
> I suggest using `Locale.US` instead of `Locale.ROOT`. Although it works, `Locale.ROOT` is an invariant locale where theoretically you cannot assume the decimal point is a period. Using `Locale.US` assures that assumption, and also aligns with other similar test cases.

Sure, changed to `Locale.US` in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15066#discussion_r1277801468