<i18n dev> RFR: 8167252: Some of Charset.availableCharsets() does not contain itself

Wed Jun 14 17:18:58 UTC 2023

On Wed, 14 Jun 2023 16:47:40 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Adding themselves into their `contains()` method will fix it.

Changes look fine over all.  

It might be worth considering updating this to use junit at some point as a separate clean up activity as it could further streamline the test

test/jdk/java/nio/charset/Charset/Contains.java line 108:

> 106:     }
> 107: 
> 108:     static void selfContainmentTest() {

Be nice to add a comment regarding the purpose of the test

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14473#pullrequestreview-1479953238
PR Review Comment: https://git.openjdk.org/jdk/pull/14473#discussion_r1229937043