<i18n dev> RFR: 8167252: Some of Charset.availableCharsets() does not contain itself [v2]

Naoto Sato naoto at openjdk.org
Thu Jun 15 16:37:12 UTC 2023


On Wed, 14 Jun 2023 18:08:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Adding themselves into their `contains()` method will fix it.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refined the test

Thanks for the review, Jai.
As to `PropertyResourceBundleCharset`, yes it is an internal implementation as Alan mentioned, to auto detect UTF-8/ISO-8859-1, so even though `contains()` does not include itself, it is fine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14473#issuecomment-1593385179


More information about the i18n-dev mailing list