<i18n dev> RFR: 8310234: Refactor Locale tests to use JUnit [v2]

Justin Lu jlu at openjdk.org
Thu Jun 22 18:55:56 UTC 2023


On Thu, 22 Jun 2023 18:34:26 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review: Clarify LocaleConstructors.java with comment for each test method
>
> test/jdk/java/util/Locale/LocaleConstructors.java line 56:
> 
>> 54:     }
>> 55: 
>> 56:     @Test
> 
> Minor, but please consider a simple comment describing the tests intent.  Just makes it easier for future developers...

Had originally only included a blanket comment for the test class. Updated the file with a comment for each test method to clarify intent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14609#discussion_r1238915682


More information about the i18n-dev mailing list