<i18n dev> RFR: 8301492: Modernize equals() method of ResourceBundle.CacheKey and Bundles.CacheKey [v3]

[Naoto Sato]

On Fri, 23 Jun 2023 15:11:47 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Yes:
>> 
>> CacheKey(String baseName, Locale locale, Module module, Module caller) {
>>     Objects.requireNonNull(module);
>>     Objects.requireNonNull(caller);
>> 
>>     this.name = baseName;
>>     this.locale = locale;
>>     this.moduleRef = new KeyElementReference<>(module, referenceQueue, this);
>>     this.callerRef = new KeyElementReference<>(caller, referenceQueue, this);
>>     this.modulesHash = module.hashCode() ^ caller.hashCode();
>> }
>
> I'll run our CI, and if all good, I'll approve this PR. If nothing else, this change seems reasonable and correct.

Thanks Pavel for jumping in. I too think this change looks good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12328#discussion_r1240055000