<i18n dev> RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

Naoto Sato naoto at openjdk.org
Thu Jun 29 22:33:53 UTC 2023


On Thu, 29 Jun 2023 18:02:00 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR, which clarifies the parameter description of ChoiceFormat.setChoices().
> 
> `ChoiceFormat.setChoices(double[] limits, String[] formats)` claims that `formats` can either be "Format objects or Strings". It also claims that "When formatting with object Y, if the object is a NumberFormat, then ((NumberFormat) Y).format(X) is called. Otherwise Y.toString() is called".
> 
> This is not true as `formats` is an array of Strings. Thus, the second claim is impossible and unimplemented in the method itself.
> 
> The unimplemented specification should be removed from the parameter description.

Marked as reviewed by naoto (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14715#pullrequestreview-1506215477


More information about the i18n-dev mailing list