<i18n dev> RFR: 8303472: Display name for region TR [v2]
Justin Lu
jlu at openjdk.org
Wed Mar 1 23:45:49 UTC 2023
On Wed, 1 Mar 2023 22:52:09 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Supply test with changes, use unicode escapes to be consistent
>> - copyright year
>
> src/java.base/share/classes/sun/util/resources/LocaleNames.properties line 1097:
>
>> 1095: TN=Tunisia
>> 1096: TO=Tonga
>> 1097: TR=Türkiye
>
> I believe this is fine, but please confirm that this ends up correct u-umlaut when you get the text. It is somewhat a rare case where ISO-8859-1 has the character and the byte sequence differs between ISO-8859-1 and UTF-8.
Thanks for pointing that out, I switched it to just be a unicode escaped ü, as that would be more consistent with the rest of the file. I also added the changes to the test files like you suggested.
-------------
PR: https://git.openjdk.org/jdk/pull/12816
More information about the i18n-dev
mailing list