<i18n dev> RFR: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR [v3]

Justin Lu jlu at openjdk.org
Fri Mar 24 18:43:39 UTC 2023


On Wed, 15 Mar 2023 19:57:43 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Expand testing to all end of year days that roll into week 1
>
> test/jdk/java/util/Calendar/RollToMinWeek.java line 79:
> 
>> 77:         return Stream.of(
>> 78:                 // Test a variety of rolls that previously produced incorrect results
>> 79:                 Arguments.of(buildCalendar(27, 11, 2020, Locale.ENGLISH),
> 
> The first day of week depends on the region, not the language. In fact, I would prefer explicitly specifying it via a locale like `en-US-u-fw-mon`, and testing all the weekdays.

Updated the testing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13031#discussion_r1147939908


More information about the i18n-dev mailing list