<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v65]

[Jim Laskey]

On Sat, 6 May 2023 02:42:14 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   CSR recommendations
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 123:
> 
>> 121:     @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES)
>> 122:     public static final int MAX_INDY_CONCAT_ARG_SLOTS;
>> 123:     static { MAX_INDY_CONCAT_ARG_SLOTS = 200; }
> 
> I think this deserve a comment such as "use static initialize block to avoid MAX_INDY_CONCAT_ARG_SLOTS being treating as a constant for constant folding," assuming that is the intention here.

Changed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1187407224