<i18n dev> RFR: 8306597: Improve string formatting in EquivMapsGenerator.java

[Naoto Sato]

On Thu, 11 May 2023 15:40:50 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review changes to `EquivMapsGenerator.java` (which is used to generate the Locale equivalencies for the JDK).
> 
> The file previously used large concatenated Strings, which are now replaced with text blocks, in addition to some cleanup. No functionality is changed, `EquivMapsGenerator.java` builds the same.

Looks good, with some cosmetic suggestions

make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 269:

> 267:              * or visit www.oracle.com if you need additional information or have any
> 268:              * questions.
> 269:             */\n

Can be a simple new line instead of `\n`. Also holds for other text blocks.

make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 272:

> 270:             """;
> 271: 
> 272:     private static final String headerText =

Not your change, but I'd capitalize those static final Strings

make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 295:

> 293:     }
> 294: 
> 295:     private static final String getlsrText(){

getLSRText?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13935#pullrequestreview-1423387718
PR Review Comment: https://git.openjdk.org/jdk/pull/13935#discussion_r1191658464
PR Review Comment: https://git.openjdk.org/jdk/pull/13935#discussion_r1191661027
PR Review Comment: https://git.openjdk.org/jdk/pull/13935#discussion_r1191663140