<i18n dev> RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

Naoto Sato naoto at openjdk.org
Fri May 12 16:43:55 UTC 2023

On Thu, 11 May 2023 22:23:47 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review changes to `EquivMapsGenerator.java` (which is used to generate the Locale equivalencies for the JDK).
>> The file previously used large concatenated Strings, which are now replaced with text blocks, in addition to some cleanup. No functionality is changed, the Locale equivalencies builds the same.
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>   Remove more ws in text block

make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 344:

> 342:     }
> 343: 
> 344:     private static final String footerText = "    }\n\n}";

I'd prefer this one also be uppercased (and moved to a more suitable location).


PR Review Comment: https://git.openjdk.org/jdk/pull/13935#discussion_r1192593829

More information about the i18n-dev mailing list