<i18n dev> RFR: 8308046: Move Solaris related Japanese charsets from java.base to jdk.charsets module [v2]

[Naoto Sato]

On Tue, 16 May 2023 17:13:02 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8308046: Move Solaris related Japanese charsets from java.base to jdk.charsets module
>
> I now think it is better simply removing Solaris-related charsets, as moving them from java.base to jdk.charsets would require unnecessary code changes in non-Solaris code.

> Hello @naotoj . I'm not sure we can remove Solaris related charsets. Somebody may use them for text communication between Solaris.

OK, maybe not now.

I think the fix may be simplified by changing access for those `DoubleByte-X.java.template` internals, such as `DecodeHolder` to `public`, instead of introducing those access methods. You can import classes in `java.base/sun.nio.cs` with the wild card so that it would work on all platforms (`Big5` either in `java.base` or `jdk.charsets`)

Also, please drop `Japanese` from the issue/PR title

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13973#issuecomment-1552210567