<i18n dev> RFR: 8308046: Move Solaris related charsets from java.base to jdk.charsets module [v2]

Ichiroh Takiguchi itakiguchi at openjdk.org
Mon May 22 14:21:56 UTC 2023


On Sat, 20 May 2023 17:26:53 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Hello @naotoj .
>> I'd like to confirm about DoubleByte-X.java.template and EUC_JP.java.template.
>> I think the values are package-private.
>> Even if class is changed to `public`, the classes in`sun.nio.cs.ext` package could not access to these values in `sun.nio.cs` package...
>> I may be misunderstanding your suggestion, could you tell me more ?
>
>> I think the values are package-private. Even if class is changed to `public`, the classes in`sun.nio.cs.ext` package could not access to these values in `sun.nio.cs` package... 
> 
> I meant making those package-private fields public. I believe it's OK because java.base/sun.nio.cs package is only exported to jdk.charsets module.

Thanks @naotoj .
I changed related fields to `public`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13973#issuecomment-1557308396


More information about the i18n-dev mailing list