<i18n dev> RFR: 8159023: Engineering notation of DecimalFormat does not work as documented [v2]

Justin Lu jlu at openjdk.org
Mon May 22 23:07:51 UTC 2023

On Mon, 22 May 2023 20:41:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>   Review: Use Static dfs, error message, and exponent digit. Hard code min and max digits instead of calculating at runtime
> test/jdk/java/text/Format/DecimalFormat/MantissaDigits.java line 89:
>> 87:             // Test the new definition of the Mantissa
>> 88:             Integer calculatedDigits = Math
>> 89:                     .min(Math.max(zeroes, originalNumDigits), (hashes+zeroes));
> Could we make those expected numbers into the `Arguments` so that there is no need to calculate in the test case at runtime? I think that would be more readable.

Thanks for the review, addressed both suggestions in the most recent commit.


PR Review Comment: https://git.openjdk.org/jdk/pull/14066#discussion_r1201272651

More information about the i18n-dev mailing list