<i18n dev> Integrated: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method
Justin Lu
jlu at openjdk.org
Wed Nov 1 21:33:10 UTC 2023
On Thu, 5 Oct 2023 20:44:55 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR which updates ChoiceFormat and MessageFormat to no longer call overridable methods in their constructors.
>
> The overridable methods called in the constructors are: _ChoiceFormat::applyPattern_, _ChoiceFormat::setChoices_, and _MessageFormat::applyPattern_. The code should be updated so that both the methods and constructors call a separate private method. Some other drive-by cleanup changes were included in the change as well.
This pull request has now been integrated.
Changeset: ee57e731
Author: Justin Lu <jlu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/ee57e731d03101ba6508297ef7d895082b04b427
Stats: 53 lines in 2 files changed: 36 ins; 3 del; 14 mod
8317612: ChoiceFormat and MessageFormat constructors call non-final public method
Reviewed-by: naoto, lancea
-------------
PR: https://git.openjdk.org/jdk/pull/16064
More information about the i18n-dev
mailing list