<i18n dev> RFR: 8316557: Make fields final in 'sun.util' package

Per Minborg pminborg at openjdk.org
Mon Nov 13 11:51:00 UTC 2023


On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> A few classes in `sun.util` package have non-final fields which could easily be marked `final`.

LGTM. See comments though.

src/java.base/share/classes/sun/util/locale/StringTokenIterator.java line 33:

> 31: package sun.util.locale;
> 32: 
> 33: public class StringTokenIterator {

The class may be `final`

-------------

Marked as reviewed by pminborg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15736#pullrequestreview-1727154051
PR Review Comment: https://git.openjdk.org/jdk/pull/15736#discussion_r1391008427


More information about the i18n-dev mailing list