<i18n dev> RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException [v3]

Joe Wang joehw at openjdk.org
Mon Nov 13 22:13:31 UTC 2023


On Mon, 13 Nov 2023 18:33:55 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> test/jdk/java/time/test/java/time/format/TestDateTimeParsing.java line 260:
>> 
>>> 258:             .toFormatter(Locale.ROOT)
>>> 259:             .toFormat();
>>> 260:         assertEquals(f.parseObject("17-30", new ParsePosition(0)), null);
>> 
>> I might have missed it, but this test doesn't seem to exercise the situation where IOOBE would happen. Though the result would be the same as it catches RuntimeException always, I wonder whether an additional test case would be helpful to verify the IOOBE situation, e.g. set the position to be greater than the length.
>
> Thanks, Joe. Added extra test for IOOBE.

Thanks, Naoto.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16586#discussion_r1391759495


More information about the i18n-dev mailing list