<i18n dev> RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags.

[Naoto Sato]

On Fri, 17 Nov 2023 09:25:40 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which allows these _j.util_ tests to launch new JVM processes with VM flags,
> 
> This is primarily done using by switching to `ProcessTools::createTestJavaProcessBuilder`.
> 
> _PropertiesTest.sh_ was updated with `@requires vm.flagless`.

test/jdk/java/util/Currency/PropertiesTest.sh line 30:

> 28: # @summary tests the capability of replacing the currency data with user
> 29: #     specified currency properties file
> 30: # @requires vm.flagless

Does this actually do anything? Since it is a shell script, it does not call any `ProcessBuilder` methods. In fact, the script includes `${TESTVMOPTS}` on launching the test java process correctly.

test/jdk/java/util/logging/LoggingDeadlock2.java line 167:

> 165: 
> 166:    private static final List<String> javaChildArgs = Arrays.asList(
> 167:        "-classpath", classpath, "LoggingDeadlock2$JavaChild");

Could use `List.of()`

test/jdk/java/util/zip/EntryCount64k.java line 3:

> 1: /*
> 2:  * Copyright (c) 2013 Google Inc. All rights reserved.
> 3:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Is this OK? The header reads `DO NOT ALTER`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16705#discussion_r1397786626
PR Review Comment: https://git.openjdk.org/jdk/pull/16705#discussion_r1397796561
PR Review Comment: https://git.openjdk.org/jdk/pull/16705#discussion_r1397797865