<i18n dev> RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

[Justin Lu]

On Fri, 17 Nov 2023 20:17:28 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> test/jdk/java/util/Currency/PropertiesTest.sh line 30:
>> 
>>> 28: # @summary tests the capability of replacing the currency data with user
>>> 29: #     specified currency properties file
>>> 30: # @requires vm.flagless
>> 
>> Does this actually do anything? Since it is a shell script, it does not call any `ProcessBuilder` methods. In fact, the script includes `${TESTVMOPTS}` on launching the test java process correctly.
>
> IIUC, using `@requires vm.flagless` simply signifies that any JVMs launched within the test do not support VM flags, (regardless if it was launched from ProcessBuilder).
> 
> However, it is odd that this test was flagged since it does pass `${TESTVMOPTS}` to `run()` like you stated. 
> 
> Perhaps @lmesnik has further understanding of what to do here?

_PropertiesTest.sh_ needs to pass both test.vm.opts **and** test.java.opts. Added `${TESTJAVAOPTS}` and unmarked as `@requires vm.flagless`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16705#discussion_r1399629617