<i18n dev> RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v2]
Naoto Sato
naoto at openjdk.org
Tue Nov 28 20:43:06 UTC 2023
On Tue, 28 Nov 2023 18:28:37 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which converts the shell test, _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from _PropertiesTest.java_. It tests both the ways to supersede the default currencies, that is, either using a custom properties file under the lib directory, or setting the path to a custom properties file via the system property.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> cleanup + naming
Looks good. Please retain the original copyright year (2007) with the refactored launcher file.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16787#pullrequestreview-1753893945
More information about the i18n-dev
mailing list