<i18n dev> RFR: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray [v2]

Naoto Sato naoto at openjdk.org
Thu Nov 30 21:51:23 UTC 2023


On Thu, 30 Nov 2023 21:26:20 GMT, Brett Okken <duke at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Arrays.fill()
>
> src/java.base/share/classes/sun/text/CompactByteArray.java line 83:
> 
>> 81:             for (i = 0; i < UNICODECOUNT; ++i) {
>> 82:                 values[i] = defaultValue;
>> 83:             }
> 
> should this be `Arrays.fill(values, defaultValue);` ?
> 
> https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Arrays.html#fill(byte%5B%5D,byte)

Thanks. Modernized.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16912#discussion_r1411299519


More information about the i18n-dev mailing list