<i18n dev> Integrated: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

Justin Lu jlu at openjdk.org
Mon Oct 2 05:46:58 UTC 2023


On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) which refines the spec of `equals()` and `hashCode()` in `java.text.Format` related classes.
> 
> The current spec for most of these methods is either  "_Overrides <method_name>_" or are incomplete/wrong (i.e. see `ChoiceFormat`).
> 
> This fix adjusts the spec to provide a consistent definition for the overridden methods and specify what is being compared/used to generate a hash code value.
> 
> For implementations that use at most a few fields, the values are stated, otherwise a more general term is used as a substitution (i.e. see `DecimalFormat`).

This pull request has now been integrated.

Changeset: 8fcf70e9
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8fcf70e931cd2e69e644c459d16d1410ce7ff3ae
Stats:     142 lines in 9 files changed: 117 ins; 1 del; 24 mod

5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

Reviewed-by: naoto, darcy

-------------

PR: https://git.openjdk.org/jdk/pull/15459


More information about the i18n-dev mailing list