<i18n dev> RFR: JDK-8317372: Refactor some NumberFormat tests to use JUnit [v3]
Naoto Sato
naoto at openjdk.org
Thu Oct 12 21:54:14 UTC 2023
On Thu, 12 Oct 2023 20:58:21 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which refactors a number of tests under `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve readability)
>> - separate the test data generation from the actual execution of the test
>> - create distinct test methods so that all the tests aren't just run under one big method (e.g. main)
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Swap grouping and decimal separator
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16035#pullrequestreview-1675263956
More information about the i18n-dev
mailing list