<i18n dev> RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

Naoto Sato naoto at openjdk.org
Tue Oct 17 16:53:41 UTC 2023


On Tue, 17 Oct 2023 02:03:06 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use ZoneOffset to parse offset
>
> Looks fine.
> (I can't help thinking that some of this pre-processing would be easier to maintain with a bit more formal parsing and creating of records for the data in these files; but that's for another time.)

Thanks for the reviews, @RogerRiggs @JoeWang-Java . I now realized that the pre-filling of GMT format in the CLDR resource would prevent COMPAT from populating its short names (as it does today), so I changed the fix not to pre-fill GMT short names. Once COMPAT is gone in the future, this workaround needs to be revisited.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16206#issuecomment-1766806066


More information about the i18n-dev mailing list