<i18n dev> RFR: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method [v2]

[Roger Riggs]

On Fri, 6 Oct 2023 18:07:37 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630) which makes the implications of overriding _ChoiceFormat::applyPattern_ and _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the method. 
>> 
>> That is, the constructors of both ChoiceFormat and MessageFormat call the public and non-final applyPattern method; any changes in the applyPattern of a subclass will be reflected in the constructors as well.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tag setChoices as well

Drive-by comment: typo  "the the" in ChoiceFormat.toPattern(): line 322

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16064#issuecomment-1777295653