<i18n dev> RFR: 8312165: Fix typos in java.desktop Swing [v5]
Alexey Ivanov
aivanov at openjdk.org
Fri Sep 1 13:16:45 UTC 2023
On Fri, 1 Sep 2023 12:26:26 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop Swing
>
> apply suggestions from review
Looks good to me except for the minor comment.
src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 1295:
> 1293: // ab[B. I'd actually prefer abB]. But, if I implement that
> 1294: // a delete at abBA] would result in aBA] vs a[BA which I
> 1295: // think is totally wrong. To get this right we need to know what
Suggestion:
// ab[B. I'd actually prefer abB]. But, if I implement that,
// a delete at abBA] would result in aBA] vs a[BA which, I
// think, is totally wrong. To get this right we need to know what
Let's drop some more commas to separate the complex sentences. Especially, the one on the first line where “that” could be interpreted as a conjunction otherwise.
I've been looking over all the changes, and again I struggled to parse the comment.
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14847#pullrequestreview-1606891522
PR Review Comment: https://git.openjdk.org/jdk/pull/14847#discussion_r1312989311
More information about the i18n-dev
mailing list