<i18n dev> RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]
Justin Lu
jlu at openjdk.org
Fri Sep 8 17:14:06 UTC 2023
> Please review this PR and associated [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the `java.text.ChoiceFormat` specification regarding its pattern.
>
> `j.text.ChoiceFormat` provides an example pattern in the class description, but beyond that it does not specify any well-defined syntax for creating a pattern. In addition, methods related to the pattern String are under-specified.
>
> The wording for `getLimits()` and `getFormats()` was also adjusted, as there are other ways to set the limits and formats beyond the constructor.
>
> The pattern syntax may be easier to view -> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
- Make starting sentence consistent with other Format classes. Improve wording, a choiceFormat does NOT have to be created with only the arrays constructor.
- Improve throws description for input that takes pattern
- Make Format definition more consistent with other Format classes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15392/files
- new: https://git.openjdk.org/jdk/pull/15392/files/e3dafe6e..4103cf9b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15392&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15392&range=03-04
Stats: 11 lines in 1 file changed: 4 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/15392.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15392/head:pull/15392
PR: https://git.openjdk.org/jdk/pull/15392
More information about the i18n-dev
mailing list