<i18n dev> RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]

[Naoto Sato]

On Fri, 8 Sep 2023 17:14:06 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and associated [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the `java.text.ChoiceFormat` specification regarding its pattern.
>> 
>> `j.text.ChoiceFormat` provides an example pattern in the class description, but beyond that it does not specify any well-defined syntax for creating a pattern. In addition, methods related to the pattern String are under-specified.
>> 
>> The wording for `getLimits()` and `getFormats()` was also adjusted, as there are other ways to set the limits and formats beyond the constructor.
>> 
>> The pattern syntax may be easier to view -> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
>
> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Make starting sentence consistent with other Format classes. Improve wording, a choiceFormat does NOT have to be created with only the arrays constructor.
>  - Improve throws description for input that takes pattern
>  - Make Format definition more consistent with other Format classes

LGTM, with a minor nit.

src/java.base/share/classes/java/text/ChoiceFormat.java line 155:

> 153:  *         "#" / "<" / "≤"
> 154:  * <i>Format:</i>
> 155:  *         Any unicode characters except the <i>Relation</i> symbols

Nit: since characters in Java are of Unicode code points, no need to mention `unicode` here.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15392#pullrequestreview-1618209049
PR Review Comment: https://git.openjdk.org/jdk/pull/15392#discussion_r1320305820