<i18n dev> RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v4]

Naoto Sato naoto at openjdk.org
Fri Sep 15 20:15:41 UTC 2023


On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which is a continuation of [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused code from the _sun.util.Calendar_ classes.
>> 
>> `forceStandardTime` is always false.
>> 
>> In addition, `locale` is never by used by _CalendarDate_ or any inheritors and can be removed.
>> 
>> As a result, _ImmutableGregorianDate_ no longer needs to override the _setLocale_ method and throw UnsupportedOperationException.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify implementation after removal of if else block

Marked as reviewed by naoto (Reviewer).

src/java.base/share/classes/sun/util/calendar/AbstractCalendar.java line 171:

> 169:             // adjust time zone and daylight saving
> 170:             // 1) 2:30am during starting-DST transition is
> 171:             //    intrepreted as 3:30am DT

Not your change, but I think this is a typo of `interpreted`

-------------

PR Review: https://git.openjdk.org/jdk/pull/15726#pullrequestreview-1629657227
PR Review Comment: https://git.openjdk.org/jdk/pull/15726#discussion_r1327739161


More information about the i18n-dev mailing list