<i18n dev> RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v5]

Andrey Turbanov aturbanov at openjdk.org
Sat Sep 16 07:40:41 UTC 2023


On Fri, 15 Sep 2023 23:31:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup existing typos
>
> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java line 160:
> 
>> 158:         unsupported();
>> 159:     }
>> 160: 
> 
> This removal does not look right. The class claims `immutable`, and yet it is now allowing setting the locale.

There is no `setLocale` method in the base class anymore. So, it's not possible to set locale in any classes which extend `BaseCalendar.Date`, including `ImmutableGregorianDate`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15726#discussion_r1327921070


More information about the i18n-dev mailing list