<i18n dev> RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v2]

[Naoto Sato]

On Mon, 18 Sep 2023 18:04:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> make/modules/java.base/gensrc/GensrcRegex.gmk line 35:
> 
>> 33: INDICCONJUNCTBREAKTEMP = $(MODULE_SRC)/share/classes/jdk/internal/util/regex/IndicConjunctBreak.java.template
>> 34: INDICCONJUNCTBREAKPROPS = $(MODULE_SRC)/share/data/unicodedata/DerivedCoreProperties.txt
>> 35: INDICCONJUNCTBREAKPARAMS = InCB\=Linker InCB\=Extend InCB\=Consonant
> 
> Please use `:=` for assignment unless you explicitly need lazy evaluation for these variables. I can't see any reason to need that here.
> 
> I don't think you need to escape `=`. What happens if you don't?

You are correct on both. Fixed.

> make/modules/java.base/gensrc/GensrcRegex.gmk line 44:
> 
>> 42: 		$(INDICCONJUNCTBREAKPROPS) \
>> 43: 		$(GENSRC_INDICCONJUNCTBREAK) \
>> 44: 		$(INDICCONJUNCTBREAKPARAMS)
> 
> Please use 4 spaces after the initial tab for continuation indentation in recipes (see point 2 and 6 https://openjdk.org/groups/build/doc/code-conventions.html).

I wasn't aware of the convention (initial tab, then spaces for further indentation). Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1329126852
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1329126899