<i18n dev> RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

Steven Loomis srl at openjdk.org
Tue Sep 19 17:02:46 UTC 2023


On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This PR is to incorporate the latest Unicode 15.1, which was released yesterday. Besides the usual character data update, an upgraded implementation of RegEx which reflects the Indic Conjunct Break specified in the latest [Unicode Annex #29 ("Unicode Text Segmentation")](https://unicode.org/reports/tr29/) is included. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Fix GensrcRegex.gmk
>  - Merge branch 'master' into JDK-8296246-Unicode15.1
>  - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - TR29 final version
>  - .md file update
>  - Final 8/28
>  - Draft 8/11
>  - GenerateExtraProperties tool
>  - initial commit

Marked as reviewed by srl (Committer).

make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java line 42:

> 40:  * Parses extra properties files of UCD, and replaces the placeholders in
> 41:  * the given template source file with the generated conditions, then emit
> 42:  * the produced .java files. For example, if the properties file has:

Suggestion:

 * Parses extra properties files of UCD, and replaces the placeholders in
 * the given template source file with the generated conditions, then emits
 * .java files. For example, if the properties file has:

src/java.base/share/legal/unicode.md line 6:

> 4: ```
> 5: 
> 6: UNICODE LICENSE V3

very  minor update

src/java.base/share/legal/unicode.md line 49:

> 47: ------------------
> 48: 
> 49: Unicode® Copyright and Terms of Use

You shouldn't need to pull in all of this — the entire license file is at https://www.unicode.org/license.txt 

It looks like you are pulling in all of https://www.unicode.org/copyright.html

You will notice that the license text no longer points you to https://www.unicode.org/copyright.html

(I worked on this change a bit)

-------------

PR Review: https://git.openjdk.org/jdk/pull/15728#pullrequestreview-1633772463
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330434732
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330439566
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330441674


More information about the i18n-dev mailing list