<i18n dev> RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing [v2]

Naoto Sato naoto at openjdk.org
Tue Sep 19 20:03:54 UTC 2023


On Tue, 19 Sep 2023 18:15:54 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Included the failed directory location in the exception message
>
> test/jdk/sun/nio/cs/TestCharsetMapping.java line 574:
> 
>> 572:             "/../../../../../make/data/charsetmapping");
>> 573:         if (!Files.exists(dir)) {
>> 574:             throw new Exception("charsetmapping directory cannot be located.");
> 
> Might be helpful to provide directory location in exception message

Good point. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15807#discussion_r1330639943


More information about the i18n-dev mailing list