<i18n dev> RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted [v3]

[Justin Lu]

On Tue, 19 Sep 2023 16:48:54 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Re-import Locale after merge for Formatter
>>  - Merge master
>>  - Replace sprintf0d with Formatter
>>  - setCache should not be overridden to be unsupported in IGD
>>  - Cleanup immutableGreg
>>  - Clarify the class with comments, also overide setCache to throw an exception
>>  - Use Override annotation within calendar system
>>  - Clarify private constructor with comment
>>  - private constructor in CalendarUtils
>>  - Make utility class 'CalendarUtils' final
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/373e37bf...f8698724
>
> src/java.base/share/classes/sun/util/calendar/CalendarUtils.java line 132:
> 
>> 130:      * Mimics sprintf(buf, "%0*d", decaimal, width).
>> 131:      */
>> 132:     public static StringBuilder sprintf0d(StringBuilder sb, int value, int width) {
> 
> Can this (and the following overload) method be eliminated? No need to mimic `sprintf` here, but using `String.format`/`formatted` should suffice?

Thanks for reviewing, replaced the two methods with Formatter (there are occurrences in _test_ as well)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15803#discussion_r1330703923