<i18n dev> RFR: JDK-8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful

Naoto Sato naoto at openjdk.org
Wed Sep 20 23:08:40 UTC 2023


On Wed, 20 Sep 2023 22:10:16 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR, which updates the exception message for java.text.DateFormatSymbols.setZoneStrings
> 
> `setZoneStrings()` takes a multi dimensional array as input. If any row does not have a length of at least 5, an _IllegalArgumentException_ is thrown. The exception should indicate why it was thrown.

Initially, I thought `%d` would fit here since `i` is an `int`, but would be a bit odd if the localized number were inserted in the English exception message. So `%s` which simply calls `toString()` is fine to me.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15849#pullrequestreview-1636620860


More information about the i18n-dev mailing list