<i18n dev> RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v7]
Justin Lu
jlu at openjdk.org
Thu Sep 28 20:39:29 UTC 2023
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) which refines the spec of `equals()` and `hashCode()` in `java.text.Format` related classes.
>
> The current spec for most of these methods is either "_Overrides <method_name>_" or are incomplete/wrong (i.e. see `ChoiceFormat`).
>
> This fix adjusts the spec to provide a consistent definition for the overridden methods and specify what is being compared/used to generate a hash code value.
>
> For implementations that use at most a few fields, the values are stated, otherwise a more general term is used as a substitution (i.e. see `DecimalFormat`).
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
Implement CSR review and WS fix in CompactNumberFormat
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15459/files
- new: https://git.openjdk.org/jdk/pull/15459/files/b4e7ddd1..d64e3f6c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15459&range=06
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15459&range=05-06
Stats: 57 lines in 9 files changed: 9 ins; 10 del; 38 mod
Patch: https://git.openjdk.org/jdk/pull/15459.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15459/head:pull/15459
PR: https://git.openjdk.org/jdk/pull/15459
More information about the i18n-dev
mailing list