<i18n dev> RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v7]

Joe Darcy darcy at openjdk.org
Fri Sep 29 18:42:50 UTC 2023


On Thu, 28 Sep 2023 20:39:29 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) which refines the spec of `equals()` and `hashCode()` in `java.text.Format` related classes.
>> 
>> The current spec for most of these methods is either  "_Overrides <method_name>_" or are incomplete/wrong (i.e. see `ChoiceFormat`).
>> 
>> This fix adjusts the spec to provide a consistent definition for the overridden methods and specify what is being compared/used to generate a hash code value.
>> 
>> For implementations that use at most a few fields, the values are stated, otherwise a more general term is used as a substitution (i.e. see `DecimalFormat`).
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement CSR review and WS fix in CompactNumberFormat

Marked as reviewed by darcy (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15459#pullrequestreview-1651265283


More information about the i18n-dev mailing list