<i18n dev> RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

Mahendra Chhipa mchhipa at openjdk.org
Thu Apr 4 17:20:00 UTC 2024


On Wed, 3 Apr 2024 20:08:43 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments.
>>   Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 72:
> 
>> 70:         Path launcher = outputPath.resolve("bin").resolve("java");
>> 71:         OutputAnalyzer analyzer =  ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea", "-esa", "HijrahConfigCheck");
>> 72:         analyzer.shouldHaveExitValue(0);
> 
> The variable `analyzer` may not be needed

Yes, I left it to improve readability.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1552113345


More information about the i18n-dev mailing list