<i18n dev> RFR: 8212895: ChronoField.INSTANT_SECONDS's range doesn't match the range of Instant [v2]

Jaikiran Pai jpai at openjdk.org
Wed Apr 10 16:17:33 UTC 2024


On Wed, 10 Apr 2024 12:27:33 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Hello Naoto, I had used `InstantSeconds` to keep it consistent with how a similar doc is used for the `EPOCH_DAY` field. Let me know if you still prefer this to be `INSTANT_SECONDS` and I will update it.
>
> With the @code tag, I initially thought it can be used programmatically, but apparently, it was simply an Enum name. Users may not notice it till they see the source (or run its `toString()`). I am fine with either way, but probably keep consistent with `EPOCH_DAY` where it is not using @code tag.

Hello Naoto, that's good point. I've updated the PR to remove `{@code}`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18674#discussion_r1559741398


More information about the i18n-dev mailing list