<i18n dev> RFR: 8319678: Several tests from corelibs areas ignore VM flags [v2]

Mahendra Chhipa mchhipa at openjdk.org
Thu Apr 11 09:07:10 UTC 2024


On Wed, 10 Apr 2024 10:57:33 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 286:
>> 
>>> 284:             OutputAnalyzer outputAnalyzer = ProcessTools.executeCommand(commands.toArray(new String[commands.size()]));
>>> 285:             if(outputAnalyzer.getExitValue() != 0) {
>>> 286:                 throw new RuntimeException(outputAnalyzer.getOutput());
>> 
>> Same comment as above `outputAnalyzer.shouldHaveExitValue(0)` would be better.
>
> Applies to some other files in this PR as well.

Thanks. Implemented in this commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560682745


More information about the i18n-dev mailing list