<i18n dev> Integrated: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714
Chen Liang
liach at openjdk.org
Fri Dec 6 14:27:46 UTC 2024
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang <liach at openjdk.org> wrote:
> Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling ClassFile API in the tests. The remainder of these flags in all tests seem to serve preview APIs (such as ScopedValue) or language features (primitive pattern, module imports, etc.), or testing the enable preview flag itself. Now there is fewer than 100 `@enablePreview` in the `test` directory.
>
> To reviewers, there are some redundant changes and notes:
>
> - There's one security test that used `ModuleInfoWriter` that depends on ClassFile API.
> - Removed unnecessary exports of `jdk.internal.classfile.impl`. Remaining uses are:
> - `BoundAttribute::payloadLen` for javac attribute tests
> - Annotation reading/writing for javac annotation tests
> - Line number changes to:
> - test/langtools/tools/javac/linenumbers/NestedLineNumberTest.java
> - test/langtools/tools/javac/linenumbers/NullCheckLineNumberTest.java
> - Move from legacy jdk.internal.classfile to java.lang.classfile in:
> - test/langtools/tools/javac/NoStringToLower.java and
> - test/langtools/tools/javac/T8003967/DetectMutableStaticFields.java
> - Weird annotation processor behavior in test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java
>
> - Without preview and using explicit file name, the javac task fails; using the builder live AP object works both with and without preview.
>
> Testing: tier 1-5. Please inform me if any of these tests belong to higher tiers.
This pull request has now been integrated.
Changeset: 49664195
Author: Chen Liang <liach at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/496641955041c5e48359e6256a4a61812653d900
Stats: 634 lines in 360 files changed: 2 ins; 555 del; 77 mod
8334733: Remove obsolete @enablePreview from tests after JDK-8334714
Reviewed-by: mchung, asotona
-------------
PR: https://git.openjdk.org/jdk/pull/22420
More information about the i18n-dev
mailing list