<i18n dev> RFR: 8346773: Fix unmatched brackets in source files [v2]

Qizheng Xing qxing at openjdk.org
Tue Dec 24 03:26:24 UTC 2024


On Mon, 23 Dec 2024 14:00:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Qizheng Xing has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>>  - Do not touch files in test.
>>  - Do not touch upstream data from CLDR.
>
> doc/hotspot-unit-tests.md line 175:
> 
>> 173: there is no need to have them in error messages. Asserts print only
>> 174: compared values, they do not print any of interim variables, e.g.
>> 175: `ASSERT_TRUE(val1 == val2 && isFail(foo(8)) || i == 18)` prints only
> 
> Looking at this expression, I believe the intention is this.
> Suggestion:
> 
> `ASSERT_TRUE((val1 == val2 && isFail(foo(8))) || i == 18)` prints only

Thanks for the suggestion, updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896331528


More information about the i18n-dev mailing list