<i18n dev> RFR: 8346773: Fix unmatched brackets in source files [v2]

[Chen Liang]

On Tue, 24 Dec 2024 03:28:31 GMT, Qizheng Xing <qxing at openjdk.org> wrote:

>> test/hotspot/jtreg/testlibrary/ctw/Makefile line 50:
>> 
>>> 48:     $(TESTLIBRARY_DIR)/jdk/test/lib/util \
>>> 49:     $(TESTLIBRARY_DIR)/jtreg \
>>> 50:     -maxdepth 1 -name '*.java')
>> 
>> I wonder why this hasn't caused problems and been found long ago?  Does make just drop that stray
>> close-paren?
>
> I've tested this by running `make`, and the previous Makefile reports an error like file `test/lib/jtreg/SkippedException.java)` not found. So this fix is necessary.
> 
> I also checked the git log, this change was introduced in https://github.com/openjdk/jdk/pull/22420, not that long ago.

Hmm, apparently this is not run as part of tier 1-3, which I ran in my patch.  I wonder how this test is run.  And it means this patch needs to be backported to 24.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896838026