<i18n dev> RFR: 8324665: Loose matching of space separators in the lenient date/time parsing mode [v2]

Justin Lu jlu at openjdk.org
Fri Feb 2 22:49:01 UTC 2024


On Fri, 2 Feb 2024 20:47:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Implementing "loose matching" of space separators in both `java.time.format.DateTimeFormatter` and `java.text.DateFormat` on lenient parsing. This will effectively fix the NNBSP issues on parsing time with am/pm markers introduced with CLDR version 42 (https://inside.java/2023/03/28/quality-heads-up/). A draft CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reworded spec

Marked as reviewed by jlu (Committer).

src/java.base/share/classes/java/text/DateFormat.java line 751:

> 749:      * @implSpec A {@link Character#SPACE_SEPARATOR SPACE_SEPARATOR} in the input
> 750:      * text will match any other {@link Character#SPACE_SEPARATOR SPACE_SEPARATOR}s
> 751:      * in the pattern with the lenient parsing; otherwise, it will not match.

LGTM.

Nit: Might read better as either "in the pattern with lenient parsing" or "in the pattern when parsing is lenient"

-------------

PR Review: https://git.openjdk.org/jdk/pull/17678#pullrequestreview-1860571955
PR Review Comment: https://git.openjdk.org/jdk/pull/17678#discussion_r1476840850


More information about the i18n-dev mailing list