<i18n dev> Integrated: JDK-8325908: Finish removal of IntlTest and CollatorTest

Justin Lu jlu at openjdk.org
Fri Feb 16 17:19:59 UTC 2024


On Wed, 14 Feb 2024 23:05:25 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which fixes / finishes the rest of the IntlTest test framework removal in java.text and java.util.i18n tests.
> 
> For context, the IntlTest class only ran methods prefixed by _test_ or _Test_ with public visibility and was originally removed due to some tests spuriously passing that were not aware of the specific running requirements.
> 
> This PR includes the following changes,
> - There were some tests with package-private visibility that were never ran by IntlTest. Those tests do appear to be valid tests, and thus have been updated with `@Test` annotation.
> - The test method DFSExponenTest() in DFSExponential.java was not prefixed by test and thus never ran by IntlTest. It is a valid test and should be ran as well.
> - DateFormatRoundTripTest.java was supposed to remain a non JUnit test, however the run invocation was converted to `@run junit ...` this has been switched back to `@run main ...`
> - There were two instances of the script missing some tests that should have had their methods updated with the `@Test` annotation: APITest.java and DFSSerialization.java. These tests have been updated accordingly.

This pull request has now been integrated.

Changeset: 4c7b313e
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4c7b313e0dc917cdaffbb2ecc86d1347683acad0
Stats:     93 lines in 7 files changed: 46 ins; 20 del; 27 mod

8325908: Finish removal of IntlTest and CollatorTest

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/17858


More information about the i18n-dev mailing list