<i18n dev> RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v2]

Justin Lu jlu at openjdk.org
Thu Jan 4 19:30:00 UTC 2024


On Thu, 4 Jan 2024 19:01:31 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - cleanup comments
>>  - provide both SPI classes under build for relevant test files
>
> test/jdk/java/util/Locale/LocaleProvidersFormat.java line 30:
> 
>> 28:  * @library /test/lib
>> 29:  * @build LocaleProviders
>> 30:  *        providersrc.spi.src.tznp8013086
> 
> Although it is not needed in this test, I would list `tznp` to be built here, as the provider's meta-info includes both classes for completeness. Applies to `LocaleProvidersTimeZone` test too.

That makes sense, updated both the relevant test files as you suggested. Thank you for taking the time to review this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17257#discussion_r1442166693


More information about the i18n-dev mailing list